Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1306053017: Introduce composed tree version of lastEditableVisiblePositionBeforePositionInRoot() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of lastEditableVisiblePositionBeforePositionInRoot() This patch introduces composed tree version of |lastEditableVisiblePositionBeforePositionInRoot()| for introducing composed tree version of |VisibleSelection| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201914

Patch Set 1 : 2015-09-08T16:55:04 #

Total comments: 1

Patch Set 2 : 2015-09-08T17:46:08 Add TODO for lastEditableVisiblePositionBeforePositionInRoot() name #

Patch Set 3 : 2015-09-08T21:42:35 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M Source/core/editing/EditingUtilities.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/editing/EditingUtilitiesTest.cpp View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yoichio
lgtm https://codereview.chromium.org/1306053017/diff/1/Source/core/editing/EditingUtilitiesTest.cpp File Source/core/editing/EditingUtilitiesTest.cpp (right): https://codereview.chromium.org/1306053017/diff/1/Source/core/editing/EditingUtilitiesTest.cpp#newcode95 Source/core/editing/EditingUtilitiesTest.cpp:95: EXPECT_EQ(Position(one->firstChild(), 0), lastEditableVisiblePositionBeforePositionInRoot(Position(one, 0), host).deepEquivalent()); (one->firstChild(), 0) is ...
5 years, 3 months ago (2015-09-08 08:22:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306053017/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306053017/20001
5 years, 3 months ago (2015-09-08 09:04:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/97251)
5 years, 3 months ago (2015-09-08 09:09:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306053017/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306053017/20001
5 years, 3 months ago (2015-09-08 12:35:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306053017/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306053017/40001
5 years, 3 months ago (2015-09-08 12:43:10 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 13:42:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201914

Powered by Google App Engine
This is Rietveld 408576698