Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: Source/core/editing/EditingUtilities.h

Issue 1306053017: Introduce composed tree version of lastEditableVisiblePositionBeforePositionInRoot() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-08T21:42:35 Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/EditingUtilities.h
diff --git a/Source/core/editing/EditingUtilities.h b/Source/core/editing/EditingUtilities.h
index 82d1fce6497bf6221f47310e636940bac693b0b5..a53cd0a203dbb4818bfa0b3aa1a4b276a79ddb98 100644
--- a/Source/core/editing/EditingUtilities.h
+++ b/Source/core/editing/EditingUtilities.h
@@ -185,9 +185,9 @@ inline Position lastPositionInOrAfterNode(Node* node)
}
CORE_EXPORT Position firstEditablePositionAfterPositionInRoot(const Position&, Node*);
-Position lastEditablePositionBeforePositionInRoot(const Position&, Node*);
+CORE_EXPORT Position lastEditablePositionBeforePositionInRoot(const Position&, Node*);
CORE_EXPORT PositionInComposedTree firstEditablePositionAfterPositionInRoot(const PositionInComposedTree&, Node*);
-PositionInComposedTree lastEditablePositionBeforePositionInRoot(const PositionInComposedTree&, Node*);
+CORE_EXPORT PositionInComposedTree lastEditablePositionBeforePositionInRoot(const PositionInComposedTree&, Node*);
// Move up or down the DOM by one position.
// Offsets are computed using layout text for nodes that have layoutObjects -
@@ -243,7 +243,12 @@ void updatePositionForNodeRemoval(Position&, Node&);
// specified position due by canonicalization.
CORE_EXPORT VisiblePosition firstEditableVisiblePositionAfterPositionInRoot(const Position&, ContainerNode*);
CORE_EXPORT VisiblePositionInComposedTree firstEditableVisiblePositionAfterPositionInRoot(const PositionInComposedTree&, ContainerNode*);
-VisiblePosition lastEditableVisiblePositionBeforePositionInRoot(const Position&, ContainerNode*);
+// TODO(yosin) We should rename
+// |lastEditableVisiblePositionBeforePositionInRoot()| to a better name which
+// describes what this function returns, since it returns a position after
+// specified position due by canonicalization.
+CORE_EXPORT VisiblePosition lastEditableVisiblePositionBeforePositionInRoot(const Position&, ContainerNode*);
+CORE_EXPORT VisiblePositionInComposedTree lastEditableVisiblePositionBeforePositionInRoot(const PositionInComposedTree&, ContainerNode*);
VisiblePosition visiblePositionBeforeNode(Node&);
VisiblePosition visiblePositionAfterNode(Node&);
« no previous file with comments | « no previous file | Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698