Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1306053014: Add cld2_table_size variable to GN build. (Closed)

Created:
5 years, 3 months ago by Andrew Hayden (chromium.org)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, rmcilroy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cld2_table_size variable to GN build. This variable has been in common.gypi for some time, but was missing from GN. BUG=528257 Committed: https://crrev.com/b32a1daf9763b66e7f12a3e88e4b526589dd8479 Cr-Commit-Position: refs/heads/master@{#347576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/features.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
andrewhayden
PTAL. Followup from https://codereview.chromium.org/1327543003
5 years, 3 months ago (2015-09-05 11:58:35 UTC) #3
jbudorick
lgtm
5 years, 3 months ago (2015-09-05 16:41:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306053014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306053014/1
5 years, 3 months ago (2015-09-05 20:09:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-05 20:58:47 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 20:59:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b32a1daf9763b66e7f12a3e88e4b526589dd8479
Cr-Commit-Position: refs/heads/master@{#347576}

Powered by Google App Engine
This is Rietveld 408576698