Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1327543003: Update Android to use Compact Language Detector v2. (Closed)

Created:
5 years, 3 months ago by Andrew Hayden (chromium.org)
Modified:
5 years, 3 months ago
Reviewers:
droger, jbudorick, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Android to use Compact Language Detector v2. Android is the last remaining platform that has not yet converted to CLDv2. Sheriffs: expect to see APK size changes in the range of [-122K, +98K] bytes. See the bug for more information. As on iOS, use the smallest data tables to minimize the binary size impact. This brings language detection on Android into parity with iOS (which also uses the smallest data tables). BUG=528257 Committed: https://crrev.com/9a70dc32d62dc1a0e9a8885f2258fe612aeb1f06 Cr-Commit-Position: refs/heads/master@{#347418}

Patch Set 1 #

Patch Set 2 : delete customization from os==ios and sync changes to GN too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M build/common.gypi View 1 3 chunks +3 lines, -5 lines 0 comments Download
M build/config/features.gni View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
rmcilroy
lgtm, thanks!
5 years, 3 months ago (2015-09-04 12:54:41 UTC) #2
Andrew Hayden (chromium.org)
jbudorick@: build/* droger@: os==iOS conditional deletion of cld_version in common.gypi rmcilroy: additional sanity check
5 years, 3 months ago (2015-09-04 14:43:04 UTC) #4
droger
iOS lgtm
5 years, 3 months ago (2015-09-04 14:45:21 UTC) #5
rmcilroy
still lgtm, thanks.
5 years, 3 months ago (2015-09-04 14:50:21 UTC) #6
jbudorick
lgtm
5 years, 3 months ago (2015-09-04 15:05:01 UTC) #7
Andrew Hayden (chromium.org)
Posterity: linux_chromium_rel_ng failure is spurious and due to some kind of filesystem error with language ...
5 years, 3 months ago (2015-09-04 15:06:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327543003/20001
5 years, 3 months ago (2015-09-04 15:28:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-04 16:17:53 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 16:18:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a70dc32d62dc1a0e9a8885f2258fe612aeb1f06
Cr-Commit-Position: refs/heads/master@{#347418}

Powered by Google App Engine
This is Rietveld 408576698