Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1306023002: Simplify macro-assembler.h include dance. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-code
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify macro-assembler.h include dance. R=bmeurer@chromium.org Committed: https://crrev.com/edc898011529d5e10ada8fd5fc396c8690368870 Cr-Commit-Position: refs/heads/master@{#30320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M src/macro-assembler.h View 2 chunks +14 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-21 09:50:55 UTC) #1
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-08-22 06:59:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306023002/1
5 years, 4 months ago (2015-08-24 07:27:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 07:52:09 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 07:52:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edc898011529d5e10ada8fd5fc396c8690368870
Cr-Commit-Position: refs/heads/master@{#30320}

Powered by Google App Engine
This is Rietveld 408576698