Issue 1302293002: Remove code.h header and move ParameterCount class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302293002: Remove code.h header and move ParameterCount class. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger

Modified:
5 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove code.h header and move ParameterCount class. R=bmeurer@chromium.org Committed: https://crrev.com/8c70c20568eed75443a983eef984458c52a51d71 Cr-Commit-Position: refs/heads/master@{#30291}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -62 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/code.h	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/macro-assembler.h	View	3 chunks	+29 lines, -8 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1306023002 Patch 1

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302293002/1

5 years, 4 months ago (2015-08-21 09:49:07 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-21 10:25:29 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8c70c20568eed75443a983eef984458c52a51d71
Cr-Commit-Position: refs/heads/master@{#30291}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages