Source/core/css/parser/CSSSelectorParser.h - Issue 1305973007: Clean up empty namespace handling and fix empty namespaces in compound selectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSSelectorParser.h

Issue 1305973007: Clean up empty namespace handling and fix empty namespaces in compound selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@defaultns

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-1.xhtml ('K') | « Source/core/css/StyleSheetContents.cpp ('k') | Source/core/css/parser/CSSSelectorParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSSelectorParser.h

diff --git a/Source/core/css/parser/CSSSelectorParser.h b/Source/core/css/parser/CSSSelectorParser.h

index dc2ff08e1a7626e126cacfbe5c16ba5dc407d386..a891cffee3a5800022d2bd0a36295e62970c3d16 100644

--- a/Source/core/css/parser/CSSSelectorParser.h

+++ b/Source/core/css/parser/CSSSelectorParser.h

@@ -36,7 +36,7 @@ private:

// This doesn't include element names, since they're handled specially

PassOwnPtr<CSSParserSelector> consumeSimpleSelector(CSSParserTokenRange&);

- bool consumeName(CSSParserTokenRange&, AtomicString& name, AtomicString& namespacePrefix, bool& hasNamespace);

+ bool consumeName(CSSParserTokenRange&, AtomicString& name, AtomicString& namespacePrefix);

// These will return nullptr when the selector is invalid

PassOwnPtr<CSSParserSelector> consumeId(CSSParserTokenRange&);