Source/core/css/StyleSheetContents.cpp - Issue 1305973007: Clean up empty namespace handling and fix empty namespaces in compound selectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StyleSheetContents.cpp

Issue 1305973007: Clean up empty namespace handling and fix empty namespaces in compound selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@defaultns

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-1.xhtml ('K') | « LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-2.xhtml ('k') | Source/core/css/parser/CSSSelectorParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/StyleSheetContents.cpp

diff --git a/Source/core/css/StyleSheetContents.cpp b/Source/core/css/StyleSheetContents.cpp

index 328cf80cc95b5ca97db57d8e6c35806663716e79..5c7304253063c8bdda010bf1297a5f51fe3003cf 100644

--- a/Source/core/css/StyleSheetContents.cpp

+++ b/Source/core/css/StyleSheetContents.cpp

@@ -274,7 +274,9 @@ void StyleSheetContents::parserAddNamespace(const AtomicString& prefix, const At

const AtomicString& StyleSheetContents::determineNamespace(const AtomicString& prefix)

{

if (prefix.isNull())

- return nullAtom; // No namespace. If an element/attribute has a namespace, we won't match it.

+ return defaultNamespace();

+ if (prefix.isEmpty())

+ return emptyAtom; // No namespace. If an element/attribute has a namespace, we won't match it.

if (prefix == starAtom)

return starAtom; // We'll match any namespace.

return m_namespaces.get(prefix);