Issue 1305943002: Merge 200894 "Touch scrolling in list picker shouldn't close the..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1305943002: Merge 200894 "Touch scrolling in list picker shouldn't close the..." (Closed)

Created:
5 years, 4 months ago by keishi

Modified:
5 years, 4 months ago

Reviewers:
keishi

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2454/

Project:
SWITCH_TO_GIT_ALREADY

Visibility:
Public.

More Reviews

Description

Merge 200894 "Touch scrolling in list picker shouldn't close the..." > Touch scrolling in list picker shouldn't close the popup > > Touch dragging should select the item under the finger only if the popup is not scrolling. This matches IE behavior. > > When touch begins, we enter "touch select mode". And when a scroll event is fired we disengage "touch select mode". > > BUG=493033 > > Review URL: https://codereview.chromium.org/1287003002 TBR=keishi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200952

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -6 lines)			Patch
M	LayoutTests/fast/forms/select/popup-menu-touch-operations.html	View	2 chunks	+75 lines, -1 line	0 comments	Download
M	LayoutTests/fast/forms/select/popup-menu-touch-operations-expected.txt	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	LayoutTests/platform/mac/fast/forms/select/popup-menu-touch-operations-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/resources/listPicker.js	View	3 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r200952.

Expand Messages | Collapse Messages