Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1287003002: Touch scrolling in list picker shouldn't close the popup (Closed)

Created:
5 years, 4 months ago by keishi
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Touch scrolling in list picker shouldn't close the popup Touch dragging should select the item under the finger only if the popup is not scrolling. This matches IE behavior. When touch begins, we enter "touch select mode". And when a scroll event is fired we disengage "touch select mode". BUG=493033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200894

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebaseline mac test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -6 lines) Patch
M LayoutTests/fast/forms/select/popup-menu-touch-operations.html View 1 2 chunks +75 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/select/popup-menu-touch-operations-expected.txt View 1 1 chunk +8 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/select/popup-menu-touch-operations-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/resources/listPicker.js View 1 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
keishi
PTAL
5 years, 4 months ago (2015-08-14 05:50:41 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-14 05:55:44 UTC) #3
tkent
Thank you for fixing it!
5 years, 4 months ago (2015-08-14 05:55:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287003002/20001
5 years, 4 months ago (2015-08-14 09:04:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/99076)
5 years, 4 months ago (2015-08-14 09:58:58 UTC) #8
keishi
I was seeing selection moving while scrolling on Ubuntu. I confirmed that this is a ...
5 years, 4 months ago (2015-08-20 04:53:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287003002/40001
5 years, 4 months ago (2015-08-20 04:54:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22142)
5 years, 4 months ago (2015-08-20 05:25:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287003002/40001
5 years, 4 months ago (2015-08-20 05:32:17 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22158)
5 years, 4 months ago (2015-08-20 05:58:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287003002/40001
5 years, 4 months ago (2015-08-20 09:27:17 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 10:26:27 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200894

Powered by Google App Engine
This is Rietveld 408576698