Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java

Issue 1305883002: Show "storage almost full" message when a page is saved offline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybots Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
index 26ff8c85bc4bcfe6bd594e73d8a20f418d1ad741..5e62bead7af8c3f6661bb030053807ed5988b7af 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.offline_pages;
+import android.os.Environment;
+
import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
@@ -23,6 +25,8 @@ import java.util.List;
@JNINamespace("offline_pages::android")
public final class OfflinePageBridge {
+ private static final long STORAGE_ALMOST_FULL_THRESHOLD_BYTES = 10L * (1 << 20); // 10M
+
private long mNativeOfflinePageBridge;
private boolean mIsNativeOfflinePageModelLoaded;
private final ObserverList<OfflinePageModelObserver> mObservers =
@@ -94,6 +98,15 @@ public final class OfflinePageBridge {
}
/**
+ * Returns true if the stoarge is almost full which indicates that the user probably needs to
+ * free up some space.
+ */
+ public static boolean isStorageAlmostFull() {
+ return Environment.getExternalStorageDirectory().getUsableSpace()
+ < STORAGE_ALMOST_FULL_THRESHOLD_BYTES;
+ }
+
+ /**
* Destroys native offline pages bridge. It should be called during
* destruction to ensure proper cleanup.
*/

Powered by Google App Engine
This is Rietveld 408576698