Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1977)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

Issue 1305883002: Show "storage almost full" message when a page is saved offline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybots Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
index 85fd965d69307c825d40b59833268005c84836a5..93fa7dff5e4b17c239db6c38eb0820dfd45d960d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
@@ -23,6 +23,7 @@ import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarksModel.AddBookmarkCallback;
import org.chromium.chrome.browser.favicon.FaviconHelper;
+import org.chromium.chrome.browser.offline_pages.OfflinePageBridge;
import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
@@ -98,12 +99,23 @@ public class EnhancedBookmarkUtils {
}
};
- int messageId = bookmarkModel.getOfflinePageBridge() == null
- ? R.string.enhanced_bookmark_page_saved
- : R.string.enhanced_bookmark_page_saved_offline_pages;
+ int messageId;
+ int buttonId;
+ OfflinePageBridge offlinePageBridge = bookmarkModel.getOfflinePageBridge();
+ if (offlinePageBridge == null) {
+ messageId = R.string.enhanced_bookmark_page_saved;
+ buttonId = R.string.enhanced_bookmark_item_edit;
+ } else {
+ boolean almostFull = offlinePageBridge.isStorageAlmostFull();
+ messageId = almostFull
+ ? R.string.enhanced_bookmark_page_saved_offline_pages_storage_near_full
+ : R.string.enhanced_bookmark_page_saved_offline_pages;
+ // TODO(fgorski): show "FREE UP SPACE" button.
+ buttonId = R.string.enhanced_bookmark_item_edit;
+ }
snackbarManager.showSnackbar(Snackbar.make(
activity.getString(messageId), snackbarController)
- .setAction(activity.getString(R.string.enhanced_bookmark_item_edit), pair));
+ .setAction(activity.getString(buttonId), pair));
}
};
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698