Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305733003: Don't filter store buffer after sweeping. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@store-buffer-filtering-for-free
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't filter store buffer after sweeping. Additionally, this CL moves a bit of code around to free up more memory before compaction starts. BUG= Committed: https://crrev.com/267381d9789419922c959d6ea44bbd1b17641e1f Cr-Commit-Position: refs/heads/master@{#30275}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -24 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 4 chunks +11 lines, -11 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 2 chunks +15 lines, -12 lines 0 comments Download

Depends on Patchset:

Issue 1298183003 Patch 1

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-20 14:27:16 UTC) #2
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-20 15:05:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305733003/20001
5 years, 4 months ago (2015-08-20 15:06:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 15:33:11 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 15:33:29 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/267381d9789419922c959d6ea44bbd1b17641e1f
Cr-Commit-Position: refs/heads/master@{#30275}

Powered by Google App Engine
This is Rietveld 408576698