Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1298183003: Large objects do not require special handling anymore when they are freed. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Large objects do not require special handling anymore when they are freed. Invalid slots in large objects can only occur when large objects became dead. These slots are filtered out already after marking. BUG= Committed: https://crrev.com/a4bcd81aed29e75c8be935274e0e9c2dbbf48e40 Cr-Commit-Position: refs/heads/master@{#30273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-20 12:29:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298183003/1
5 years, 4 months ago (2015-08-20 12:32:57 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-20 12:32:59 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298183003/1
5 years, 4 months ago (2015-08-20 12:35:26 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-20 12:57:21 UTC) #10
Michael Lippautz
LGTM
5 years, 4 months ago (2015-08-20 13:10:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298183003/1
5 years, 4 months ago (2015-08-20 14:20:43 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 14:21:53 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 14:22:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4bcd81aed29e75c8be935274e0e9c2dbbf48e40
Cr-Commit-Position: refs/heads/master@{#30273}

Powered by Google App Engine
This is Rietveld 408576698