Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305433004: DevTools: fix assertion failure when collecting async calls stacks (Closed)

Created:
5 years, 4 months ago by yurys
Modified:
5 years, 4 months ago
Reviewers:
esprehn, sergeyv, pfeldman
CC:
esprehn, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix assertion failure when collecting async calls stacks BUG=522674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200854

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +5 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (5 generated)
yurys
5 years, 4 months ago (2015-08-19 21:24:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305433004/1
5 years, 4 months ago (2015-08-19 21:24:32 UTC) #4
pfeldman
lgtm
5 years, 4 months ago (2015-08-19 21:39:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305433004/1
5 years, 4 months ago (2015-08-19 21:45:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200854
5 years, 4 months ago (2015-08-19 22:33:28 UTC) #9
esprehn
https://codereview.chromium.org/1305433004/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp File Source/core/inspector/InspectorDebuggerAgent.cpp (right): https://codereview.chromium.org/1305433004/diff/1/Source/core/inspector/InspectorDebuggerAgent.cpp#newcode264 Source/core/inspector/InspectorDebuggerAgent.cpp:264: OwnPtr<ScriptForbiddenScope::AllowUserAgentScript> allowScripting; I think you want to use Optional<ScriptForbiddenScope::AllowUserAgentScript> ...
5 years, 4 months ago (2015-08-19 22:43:53 UTC) #11
yurys
5 years, 4 months ago (2015-08-20 00:05:10 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/1305433004/diff/1/Source/core/inspector/Inspe...
File Source/core/inspector/InspectorDebuggerAgent.cpp (right):

https://codereview.chromium.org/1305433004/diff/1/Source/core/inspector/Inspe...
Source/core/inspector/InspectorDebuggerAgent.cpp:264:
OwnPtr<ScriptForbiddenScope::AllowUserAgentScript> allowScripting;
On 2015/08/19 22:43:53, esprehn wrote:
> I think you want to use Optional<ScriptForbiddenScope::AllowUserAgentScript>
> instead.

Didn't know that we have Optional, thanks! 
https://codereview.chromium.org/1286383007

Powered by Google App Engine
This is Rietveld 408576698