Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286383007: Use Optional instead of OwnPtr for holding AllowUserAgentScript (Closed)

Created:
5 years, 4 months ago by yurys
Modified:
5 years, 4 months ago
Reviewers:
esprehn, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use Optional instead of OwnPtr for holding AllowUserAgentScript BUG=522674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/core/inspector/AsyncCallTracker.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yurys
5 years, 4 months ago (2015-08-20 00:05:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286383007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286383007/1
5 years, 4 months ago (2015-08-20 00:06:13 UTC) #4
esprehn
lgtm
5 years, 4 months ago (2015-08-20 00:09:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286383007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286383007/1
5 years, 4 months ago (2015-08-20 00:09:45 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 01:25:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200870

Powered by Google App Engine
This is Rietveld 408576698