Enable errorprone compiler on the chromium.fyi Android Builder.

Enable errorprone compiler on the chromium.fyi Android Builder.

Enabling errorprone on this bot to test. If everything seems stable,
I will change errorprone to be default for everyone.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296611

[mikecase (-- gone --), 2015-08-21 21:37:21]

mikecase@chromium.org changed reviewers:
+ luqui@chromium.org

[mikecase (-- gone --), 2015-08-21 21:37:21]

This CL depends on https://codereview.chromium.org/1286613002
Once the above CL lands, I would like to test our errorprone on the fyi builder.

[luqui, 2015-08-24 17:43:08]

lgtm

[mikecase (-- gone --), 2015-08-27 19:40:26]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-08-27 19:40:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305303002/1

[commit-bot: I haz the power, 2015-08-27 19:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 19:45:31]

Try jobs failed on following builders:
  build_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit...)

[mikecase (-- gone --), 2015-08-27 21:03:37]

mikecase@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[mikecase (-- gone --), 2015-08-27 21:03:38]

+ phajdan.jr@chromium.org for owners review of chromium_tests/

[Paweł Hajdan Jr., 2015-08-28 11:44:25]

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/chromium_config.py (right):

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/chromium_config.py:174: def
errorprone_builder(c):
Why does the name of this config entry include "builder"?

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/config.py (right):

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/config.py:199: def
errorprone_builder(c):
Why is this needed?

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1562:
'android_config': 'errorprone_builder',
Why not just use chromium_apply_config to apply the errorprone_builder config?

[mikecase (-- gone --), 2015-08-28 18:36:06]

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/chromium_config.py (right):

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/chromium_config.py:174: def
errorprone_builder(c):
On 2015/08/28 at 11:44:25, Paweł Hajdan Jr. wrote:
> Why does the name of this config entry include "builder"?

Changed.

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/config.py (right):

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/config.py:199: def
errorprone_builder(c):
On 2015/08/28 at 11:44:25, Paweł Hajdan Jr. wrote:
> Why is this needed?

Removed.

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1305303002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:1562:
'android_config': 'errorprone_builder',
On 2015/08/28 at 11:44:25, Paweł Hajdan Jr. wrote:
> Why not just use chromium_apply_config to apply the errorprone_builder config?

Done.

[Paweł Hajdan Jr., 2015-08-31 11:48:16]

LGTM w/comment (please address it or get another round of review)

https://codereview.chromium.org/1305303002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/chromium_config.py (right):

https://codereview.chromium.org/1305303002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/chromium_config.py:173:
@CONFIG_CTX(includes=['main_builder'])
It still includes "main_builder" which is confusing - is it really needed?

[mikecase (-- gone --), 2015-09-09 17:17:24]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-09-09 17:17:25]

The patchset sent to the CQ was uploaded after l-g-t-m from luqui@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1305303002/#ps60001
(title: "Got rid of includes=main_builder. Not needed.")

[commit-bot: I haz the power, 2015-09-09 17:17:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1305303002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1305303002/60001

[commit-bot: I haz the power, 2015-09-09 17:19:50]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296611

[mikecase (-- gone --), 2015-09-09 17:35:29]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1326093005/ by mikecase@chromium.org.

The reason for reverting is: Causes Android Fyi builder to fail on compile.

http://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%...

Will investigates what is going wrong..