Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1305293002: Clone the subframe FrameNavigationEntries for in-page navigations. (Closed)

Created:
5 years, 4 months ago by Charlie Reis
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clone the subframe FrameNavigationEntries for in-page navigations. This avoids crashes when subsequently navigating in subframes or adding child frames to them. BUG=522193 TEST=See bug comment 4 for repro steps.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -23 lines) Patch
M content/browser/frame_host/navigation_controller_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 6 chunks +20 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +110 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 3 chunks +9 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 2 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Charlie Reis
3 years, 5 months ago (2017-07-11 22:36:57 UTC) #1
Description was changed from

==========
Clone the subframe FrameNavigationEntries for in-page navigations.

This avoids crashes when subsequently navigating in subframes or
adding child frames to them.

BUG=522193
TEST=See bug comment 4 for repro steps.
==========

to

==========
Clone the subframe FrameNavigationEntries for in-page navigations.

This avoids crashes when subsequently navigating in subframes or
adding child frames to them.

BUG=522193
TEST=See bug comment 4 for repro steps.
==========

Powered by Google App Engine
This is Rietveld 408576698