content/browser/frame_host/navigation_controller_impl.h - Issue 1305293002: Clone the subframe FrameNavigationEntries for in-page navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 1305293002: Clone the subframe FrameNavigationEntries for in-page navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_impl.h

diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h

index a5136d932bd05c2d43f79c316699c4e17e8e459b..25050609dcf16780d51c9fc3de938fc054095bd0 100644

--- a/content/browser/frame_host/navigation_controller_impl.h

+++ b/content/browser/frame_host/navigation_controller_impl.h

@@ -272,6 +272,7 @@ class CONTENT_EXPORT NavigationControllerImpl

void RendererDidNavigateToNewPage(

RenderFrameHostImpl* rfh,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

+ bool is_in_page,

bool replace_entry);

void RendererDidNavigateToExistingPage(

RenderFrameHostImpl* rfh,

@@ -281,7 +282,8 @@ class CONTENT_EXPORT NavigationControllerImpl

const FrameHostMsg_DidCommitProvisionalLoad_Params& params);

void RendererDidNavigateNewSubframe(

RenderFrameHostImpl* rfh,

- const FrameHostMsg_DidCommitProvisionalLoad_Params& params);

+ const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

+ bool is_in_page);

bool RendererDidNavigateAutoSubframe(

RenderFrameHostImpl* rfh,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params);

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »