Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1305233002: Delete obsolete auto_login_infobar_delegate. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete obsolete auto_login_infobar_delegate. This was once used on Android, but Android no longer uses autologin infobars. TBR=cpu@chromium.org BUG=422495 Committed: https://crrev.com/2d8625456fa7f387be6dc970ec05a7fe64b48df1 Cr-Commit-Position: refs/heads/master@{#344922}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -341 lines) Patch
A + chrome/android/java/res/drawable-hdpi/infobar_savepassword.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/infobar_savepassword_autologin.png View 1 2 Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_savepassword.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/infobar_savepassword_autologin.png View 1 2 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/infobar_savepassword.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/infobar_savepassword_autologin.png View 1 2 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/infobar_savepassword.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/infobar_savepassword_autologin.png View 1 2 Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/infobar_savepassword.png View 1 2 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/infobar_savepassword_autologin.png View 1 2 Binary file 0 comments Download
M chrome/android/java/res/layout/password_generation_popup_suggestion.xml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/resource_id.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
D chrome/browser/ui/auto_login_infobar_delegate.h View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/ui/auto_login_infobar_delegate.cc View 1 chunk +0 lines, -231 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M components/infobars/core/infobar_delegate.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (10 generated)
newt (away)
Do you agree that this can be removed? It was only compiled on Android and ...
5 years, 4 months ago (2015-08-21 18:07:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305233002/20001
5 years, 4 months ago (2015-08-21 18:08:07 UTC) #4
newt (away)
Note: looks like there a number of other little things that can be removed before ...
5 years, 4 months ago (2015-08-21 18:10:57 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-21 19:00:38 UTC) #7
newt (away)
PTAL
5 years, 4 months ago (2015-08-21 19:50:48 UTC) #8
acleung1
On 2015/08/21 19:50:48, newt wrote: > PTAL +1
5 years, 4 months ago (2015-08-21 20:11:35 UTC) #9
Roger Tawa OOO till Jul 10th
lgtm
5 years, 4 months ago (2015-08-21 20:30:03 UTC) #10
newt (away)
+pkasting for infobar_delegate.[cc|h] and auto_login_infobar_delegate.[cc|h] TBR cpu@chromium.org for theme_resources.grd
5 years, 4 months ago (2015-08-21 21:57:01 UTC) #12
Peter Kasting
LGTM Didn't I file a bug for this? Seems like this should have a BUG=
5 years, 4 months ago (2015-08-21 22:00:51 UTC) #13
newt (away)
On 2015/08/21 22:00:51, Peter Kasting wrote: > LGTM > > Didn't I file a bug ...
5 years, 4 months ago (2015-08-21 22:16:16 UTC) #14
newt (away)
On 2015/08/21 22:16:16, newt wrote: > On 2015/08/21 22:00:51, Peter Kasting wrote: > > LGTM ...
5 years, 4 months ago (2015-08-21 22:17:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305233002/60001
5 years, 4 months ago (2015-08-21 22:20:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/88300) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-21 22:24:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305233002/80001
5 years, 4 months ago (2015-08-21 22:41:28 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/91548)
5 years, 4 months ago (2015-08-21 22:54:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305233002/80001
5 years, 4 months ago (2015-08-21 22:57:29 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-21 23:52:44 UTC) #27
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 23:53:22 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2d8625456fa7f387be6dc970ec05a7fe64b48df1
Cr-Commit-Position: refs/heads/master@{#344922}

Powered by Google App Engine
This is Rietveld 408576698