tools/testing/dart/test_progress.dart - Issue 13052004: Don't close stdout/stderr in CompactProgressIndicator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_progress.dart

Issue 13052004: Don't close stdout/stderr in CompactProgressIndicator (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_progress.dart

diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart

index 72da366264ced51be095c34a7d0d2d625c0ec6a3..773321746121a98932eee4574e604cfa08376491 100644

--- a/tools/testing/dart/test_progress.dart

+++ b/tools/testing/dart/test_progress.dart

@@ -429,10 +429,8 @@ abstract class CompactIndicator extends ProgressIndicator {

if (_failedTests > 0) {

// We may have printed many failure logs, so reprint the summary data.

_printProgress();

- print('');

}

- stdout.close();

- stderr.close();

+ print('');

}

void _printStartProgress(TestCase test) => _printProgress();

« no previous file with comments | « no previous file | no next file » | no next file with comments »