Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: tools/testing/dart/test_progress.dart

Issue 13052004: Don't close stdout/stderr in CompactProgressIndicator (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_progress; 5 library test_progress;
6 6
7 import "dart:io"; 7 import "dart:io";
8 import "dart:io" as io; 8 import "dart:io" as io;
9 import "http_server.dart" as http_server; 9 import "http_server.dart" as http_server;
10 import "status_file_parser.dart"; 10 import "status_file_parser.dart";
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 } 422 }
423 423
424 abstract class CompactIndicator extends ProgressIndicator { 424 abstract class CompactIndicator extends ProgressIndicator {
425 CompactIndicator(DateTime startTime) 425 CompactIndicator(DateTime startTime)
426 : super(startTime); 426 : super(startTime);
427 427
428 void allDone() { 428 void allDone() {
429 if (_failedTests > 0) { 429 if (_failedTests > 0) {
430 // We may have printed many failure logs, so reprint the summary data. 430 // We may have printed many failure logs, so reprint the summary data.
431 _printProgress(); 431 _printProgress();
432 print('');
433 } 432 }
434 stdout.close(); 433 print('');
435 stderr.close();
436 } 434 }
437 435
438 void _printStartProgress(TestCase test) => _printProgress(); 436 void _printStartProgress(TestCase test) => _printProgress();
439 void _printDoneProgress(TestCase test) => _printProgress(); 437 void _printDoneProgress(TestCase test) => _printProgress();
440 438
441 void _printProgress(); 439 void _printProgress();
442 } 440 }
443 441
444 442
445 class CompactProgressIndicator extends CompactIndicator { 443 class CompactProgressIndicator extends CompactIndicator {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 print('@@@STEP_FAILURE@@@'); 508 print('@@@STEP_FAILURE@@@');
511 print('@@@BUILD_STEP $stepName failures@@@'); 509 print('@@@BUILD_STEP $stepName failures@@@');
512 for (String line in _failureSummary) { 510 for (String line in _failureSummary) {
513 print(line); 511 print(line);
514 } 512 }
515 print(''); 513 print('');
516 } 514 }
517 super.allDone(); 515 super.allDone();
518 } 516 }
519 } 517 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698