Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1305153004: Focus comes on the 'close button' in find bar when selecting 'Enter' key. (Closed)

Created:
5 years, 4 months ago by Deepak
Modified:
5 years, 3 months ago
Reviewers:
msw, AKV
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Focus comes on the 'close button' in find bar when selecting 'Enter' key. Now NotifyClick() takes ui::Event from CustomButton::OnKeyPressed() directly instead of synthetic mouse event, So We need to change the foucs to text box when user select 'Enter' from the keyboard when navigation key is focused in FindViewBar. BUG=524373 Committed: https://crrev.com/8afc21e1982fa5f0d2a01d8a9c3a3e692d3f23d3 Cr-Commit-Position: refs/heads/master@{#346311}

Patch Set 1 #

Patch Set 2 : Adding test case. #

Total comments: 16

Patch Set 3 : Changes as per review comments. #

Total comments: 12

Patch Set 4 : Changes as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M chrome/browser/ui/views/find_bar_view.cc View 1 2 3 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/find_bar_views_interactive_uitest.cc View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Deepak
PTAL
5 years, 4 months ago (2015-08-26 08:00:00 UTC) #2
AKV
peer review looks good to me!
5 years, 3 months ago (2015-08-26 10:18:09 UTC) #4
Deepak
On 2015/08/26 10:18:09, AKV wrote: > peer review looks good to me! @msw PTAL
5 years, 3 months ago (2015-08-26 11:01:38 UTC) #5
msw
https://codereview.chromium.org/1305153004/diff/20001/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc (right): https://codereview.chromium.org/1305153004/diff/20001/chrome/browser/ui/views/find_bar_view.cc#newcode413 chrome/browser/ui/views/find_bar_view.cc:413: .key_code() == ui::VKEY_RETURN)) { The same defect occurs for ...
5 years, 3 months ago (2015-08-26 18:44:32 UTC) #6
Deepak
Thanks for review. PTAL https://codereview.chromium.org/1305153004/diff/20001/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc (right): https://codereview.chromium.org/1305153004/diff/20001/chrome/browser/ui/views/find_bar_view.cc#newcode413 chrome/browser/ui/views/find_bar_view.cc:413: .key_code() == ui::VKEY_RETURN)) { On ...
5 years, 3 months ago (2015-08-27 05:31:04 UTC) #7
msw
https://codereview.chromium.org/1305153004/diff/20001/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc (right): https://codereview.chromium.org/1305153004/diff/20001/chrome/browser/ui/views/find_bar_view.cc#newcode413 chrome/browser/ui/views/find_bar_view.cc:413: .key_code() == ui::VKEY_RETURN)) { On 2015/08/27 05:31:04, Deepak wrote: ...
5 years, 3 months ago (2015-08-27 18:09:03 UTC) #8
Deepak
@msw Thanks for review and providing comments. Changes done as suggested. PTAL https://codereview.chromium.org/1305153004/diff/40001/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc ...
5 years, 3 months ago (2015-08-28 04:20:21 UTC) #9
msw
lgtm
5 years, 3 months ago (2015-08-28 16:43:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305153004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305153004/60001
5 years, 3 months ago (2015-08-29 04:54:47 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-29 05:57:06 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 05:58:01 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8afc21e1982fa5f0d2a01d8a9c3a3e692d3f23d3
Cr-Commit-Position: refs/heads/master@{#346311}

Powered by Google App Engine
This is Rietveld 408576698