Focus comes on the 'close button' in find bar when selecting 'Enter' key.

chrome/browser/ui/views/find_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/find_bar_view.h"
 
 #include <algorithm>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 388 matching lines @@
   switch (sender->tag()) {
     case FIND_PREVIOUS_TAG:
     case FIND_NEXT_TAG:
       if (!find_text_->text().empty()) {
         FindTabHelper* find_tab_helper = FindTabHelper::FromWebContents(
             find_bar_host()->GetFindBarController()->web_contents());
         find_tab_helper->StartFinding(find_text_->text(),
                                       sender->tag() == FIND_NEXT_TAG,
                                       false);  // Not case sensitive.
       }
-      if (event.IsMouseEvent()) {
-        // If mouse event, we move the focus back to the text-field, so that the
-        // user doesn't have to click on the text field to change the search. We
-        // don't want to do this for keyboard clicks on the button, since the
-        // user is more likely to press FindNext again than change the search
-        // query.
+      // As NotifyClick() now takes ui::Event directly so event can be mouse
+      // event or the key event.
+      if (event.IsMouseEvent() || (event.IsKeyEvent() &&
+                                   static_cast<const ui::KeyEvent&>(event)
+                                           .key_code() == ui::VKEY_RETURN)) {

[msw, 2015/08/26 18:44:32]

The same defect occurs for the space key, and perhaps others, so this isn't
complete, and likely the wrong fix. If we just want the old behavior, remove the
|event| conditions and always focus the textfield. But I think it should do:
A) If it's a mouse event, focus the textfield (as the code already did).
B) If it's a key event (Enter, Space, whatever...) leave the focus on the same
button (up or down), so users can focus the '^' (find previous) button and
repeatedly hit [RETURN] or [SPACE] to repeatedly find previous instances of the
search phrase. Otherwise, pressing a key to invoke '^' (find previous) will
focus the textfield and the following [ENTER] key event will find *next*
(switching direction from the last key press), or the following [SPACE] key
press will replace the textfield text with a space character (unexpected).

[Deepak, 2015/08/27 05:31:04]

Thanks for detailed explanation. As the current issue have release blocker tag,
so I am restoring it to the old behavior i.e moving the focus to text field for
the mouse and key events.
I will make separate patch for your suggestion for keeping the focus on the same
button so that user's [Return] or [Space] key will search previous/next instance
of the search phrase for key events.

[msw, 2015/08/27 18:09:02]

Acknowledged.

+        // If mouse event or key event with Enter key, we move the focus back
+        // to the text-field, so that the user doesn't have to click on the
+        // text field to change the search.
         find_text_->RequestFocus();
       }
       break;
     case CLOSE_TAG:
       find_bar_host()->GetFindBarController()->EndFindSession(
           FindBarController::kKeepSelectionOnPage,
           FindBarController::kKeepResultsInFindBox);
       break;
     default:
       NOTREACHED() << L"Unknown button";
@@ skipping 236 matching lines @@
 void FindBarView::OnNativeThemeChanged(const ui::NativeTheme* theme) {
   if (!ui::MaterialDesignController::IsModeMaterial())
     return;
 
   SkColor color =
       theme->GetSystemColor(ui::NativeTheme::kColorId_DialogBackground);
   set_background(views::Background::CreateSolidBackground(color));
   match_count_text_->SetBackgroundColor(color);
   match_count_text_->SetEnabledColor(kMatchTextColorMD);
 }