chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 1305143008: [Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 1305143008: [Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_layout.h » ('j') | chrome/browser/ui/cocoa/browser_window_layout.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index 99ef304ce6729e554005c42a8fe0fa3db73f2f27..ff5c9104f76e9b91d6d763734a378e71bcd769cd 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -907,6 +907,13 @@ willPositionSheet:(NSWindow*)sheet

[layout setAvatarLineWidth:[[avatar superview] cr_lineWidth]];

}

+ // Set whether the toolbar view is visible or not. For hosted apps in windows,

+ // [self hasToolbar] returns NO, but [self hasLocationBar] returns YES;

+ // however, hosted apps can independently control whether they show or hide

+ // the location bar based on the current origin. Hosted app windows do not

+ // show the bookmark bar, so this does not interfere with the positioning of

+ // that bar.

+ [layout setToolbarHidden:[toolbarController_ view].isHidden];

tapted 2015/10/12 23:56:43 use [[toolbarController_ view] isHidden] (dot not

dominickn 2015/10/15 06:22:27 Changes removed

[layout setHasToolbar:[self hasToolbar]];

[layout setToolbarHeight:NSHeight([[toolbarController_ view] bounds])];