[Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility()

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/mac/bind_objc_block.h"
@@ skipping 889 matching lines @@
   [layout setFullscreenButtonFrame:[self fullscreenButtonFrame]];
 
   if ([self shouldShowAvatar]) {
     NSView* avatar = [avatarButtonController_ view];
     [layout setShouldShowAvatar:YES];
     [layout setShouldUseNewAvatar:[self shouldUseNewAvatarButton]];
     [layout setAvatarSize:[avatar frame].size];
     [layout setAvatarLineWidth:[[avatar superview] cr_lineWidth]];
   }
 
+  // Set whether the toolbar view is visible or not. For hosted apps in windows,
+  // [self hasToolbar] returns NO, but [self hasLocationBar] returns YES;
+  // however, hosted apps can independently control whether they show or hide
+  // the location bar based on the current origin. Hosted app windows do not
+  // show the bookmark bar, so this does not interfere with the positioning of
+  // that bar.
+  [layout setToolbarHidden:[toolbarController_ view].isHidden];

[tapted, 2015/10/12 23:56:43]

use [[toolbarController_ view] isHidden]  (dot notation is only for structs)

[dominickn, 2015/10/15 06:22:27]

Changes removed

   [layout setHasToolbar:[self hasToolbar]];
   [layout setToolbarHeight:NSHeight([[toolbarController_ view] bounds])];
 
   [layout setHasLocationBar:[self hasLocationBar]];
 
   [layout setPlaceBookmarkBarBelowInfoBar:[self placeBookmarkBarBelowInfoBar]];
   [layout setBookmarkBarHidden:[bookmarkBarController_ view].isHidden];
   [layout setBookmarkBarHeight:
       NSHeight([[bookmarkBarController_ view] bounds])];
 
@@ skipping 237 matching lines @@
   return browser_->tab_strip_model()->GetActiveWebContents();
 }
 
 - (PermissionBubbleManager*)permissionBubbleManager {
   if (WebContents* contents = [self webContents])
     return PermissionBubbleManager::FromWebContents(contents);
   return nil;
 }
 
 @end  // @implementation BrowserWindowController(Private)