chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 1305143008: [Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1305143008: [Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.h ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.mm » ('j') | chrome/browser/ui/cocoa/browser_window_controller_private.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index a0154399f2bdb85034d1bf5703ec6292eb235b55..7306caade8cc256eb5215dc7a1f0288b137d0b80 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1896,6 +1896,15 @@ willAnimateFromState:(BookmarkBar::State)oldState

command.accelerator());

}

+- (void)updateToolbarVisibility:(BOOL)visible

+ withAnimation:(BOOL)animate {

+ // The toolbar section of the window layout must be redrawn when its

+ // visibility changes. Otherwise, when the toolbar is not visible, its section

+ // of the UI remains as an empty gray bar rather than not being drawn at all.

+ [toolbarController_ updateVisibility:visible withAnimation:animate];

+ [self layoutSubviews];

@end // @implementation BrowserWindowController

@implementation BrowserWindowController(Fullscreen)