[Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility()

chrome/browser/ui/cocoa/browser_window_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <cmath>
 #include <numeric>
 
 #include "base/command_line.h"
@@ skipping 973 matching lines @@
 
   [window setFrame:windowFrame display:NO];
   [chromeContentView setAutoresizesSubviews:autoresizesSubviews];
   return YES;
 }
 
 // Main method to resize browser window subviews.  This method should be called
 // when resizing any child of the content view, rather than resizing the views
 // directly.  If the view is already the correct height, does not force a
 // relayout.
 - (void)resizeView:(NSView*)view newHeight:(CGFloat)height {

[tapted, 2015/10/12 23:56:43]

BWC is a `ViewResizer` -- AnimatableView's delegate. So calling setHeight or
animateToNewHeight should end up calling this function, which is responsible for
calling layoutSubviews.

Perhaps you're missing a call to [[toolbarController animatableView]
setResizeDelegate:BWC()] -- look at bookmark_bar_controller.mm:299 . You'll
probably need an extra argument to initWithCommands, and update BWC
initWithBrowser around line 329 so that it looks a bit more like
bookmarkBarController_

The separate call to layoutSubviews in updateToolbarVisibility: shouldn't be
necessary. (Right? Or, can you explain why it is needed?)

[dominickn, 2015/10/15 06:22:27]

Done. This eliminates the need to call layoutSubviews, thanks!

   // We should only ever be called for one of the following four views.
   // |downloadShelfController_| may be nil. If we are asked to size the bookmark
   // bar directly, its superview must be this controller's content view.
   DCHECK(view);
   DCHECK(view == [toolbarController_ view] ||
          view == [infoBarContainerController_ view] ||
          view == [downloadShelfController_ view] ||
          view == [bookmarkBarController_ view]);
 
   // The infobar has insufficient information to determine its new height. It
@@ skipping 884 matching lines @@
 
 - (void)executeExtensionCommand:(const std::string&)extension_id
                         command:(const extensions::Command&)command {
   // Global commands are handled by the ExtensionCommandsGlobalRegistry
   // instance.
   DCHECK(!command.global());
   extension_keybinding_registry_->ExecuteCommand(extension_id,
                                                  command.accelerator());
 }
 
+- (void)updateToolbarVisibility:(BOOL)visible
+                  withAnimation:(BOOL)animate {
+  // The toolbar section of the window layout must be redrawn when its
+  // visibility changes. Otherwise, when the toolbar is not visible, its section
+  // of the UI remains as an empty gray bar rather than not being drawn at all.
+  [toolbarController_ updateVisibility:visible withAnimation:animate];
+  [self layoutSubviews];
+}
+
 @end  // @implementation BrowserWindowController
 
 @implementation BrowserWindowController(Fullscreen)
 
 - (void)handleLionToggleFullscreen {
   DCHECK(base::mac::IsOSLionOrLater());
   chrome::ExecuteCommand(browser_.get(), IDC_FULLSCREEN);
 }
 
 - (void)enterBrowserFullscreenWithToolbar:(BOOL)withToolbar {
@@ skipping 152 matching lines @@
 
 - (BOOL)supportsBookmarkBar {
   return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
 }
 
 - (BOOL)isTabbedWindow {
   return browser_->is_type_tabbed();
 }
 
 @end  // @implementation BrowserWindowController(WindowType)