Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6844)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 1305143008: [Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index d680763b610cd1935eb5c274027738e6f4afa6b5..3f6070368b6be64f6aee135f0cb2742d0d11b40b 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -437,6 +437,20 @@ willPositionSheet:(NSWindow*)sheet
delay:YES];
}
+- (void)showToolbar:(NSNotification*)notification {
+ if (!shouldShowToolbar_) {
+ shouldShowToolbar_ = YES;
+ [self layoutSubviews];
+ }
+}
+
+- (void)hideToolbar:(NSNotification*)notification {
+ if (shouldShowToolbar_) {
+ shouldShowToolbar_ = NO;
+ [self layoutSubviews];
+ }
+}
+
- (void)configurePresentationModeController {
BOOL fullscreen_for_tab = browser_->exclusive_access_manager()
->fullscreen_controller()
@@ -901,8 +915,13 @@ willPositionSheet:(NSWindow*)sheet
[layout setAvatarLineWidth:[[avatar superview] cr_lineWidth]];
}
- [layout setHasToolbar:[self hasToolbar]];
- [layout setToolbarHeight:NSHeight([[toolbarController_ view] bounds])];
+ if (shouldShowToolbar_) {
tapted 2015/09/08 05:55:05 I think you can read `shouldShowToolbar` by just a
dominickn 2015/10/09 06:37:02 Done.
+ [layout setHasToolbar:[self hasToolbar]];
+ [layout setToolbarHeight:NSHeight([[toolbarController_ view] bounds])];
+ } else {
+ [layout setHasToolbar:NO];
+ [layout setToolbarHeight:0];
+ }
[layout setHasLocationBar:[self hasLocationBar]];

Powered by Google App Engine
This is Rietveld 408576698