[Mac] Implement LocationBarViewMac::UpdateLocationBarVisibility()

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/mac/bind_objc_block.h"
@@ skipping 419 matching lines @@
 - (void)permissionBubbleWindowWillClose:(NSNotification*)notification {
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   [center removeObserver:self
                     name:NSWindowWillCloseNotification
                   object:[notification object]];
   [self releaseBarVisibilityForOwner:[notification object]
                        withAnimation:YES
                                delay:YES];
 }
 
+- (void)showToolbar:(NSNotification*)notification {
+  if (!shouldShowToolbar_) {
+    shouldShowToolbar_ = YES;
+    [self layoutSubviews];
+  }
+}
+
+- (void)hideToolbar:(NSNotification*)notification {
+  if (shouldShowToolbar_) {
+    shouldShowToolbar_ = NO;
+    [self layoutSubviews];
+  }
+}
+
 - (void)configurePresentationModeController {
   BOOL fullscreen_for_tab = browser_->exclusive_access_manager()
                                 ->fullscreen_controller()
                                 ->IsWindowFullscreenForTabOrPending();
   BOOL kiosk_mode =
       base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode);
   BOOL showDropdown =
       !fullscreen_for_tab && !kiosk_mode && ([self floatingBarHasFocus]);
 
   PermissionBubbleManager* manager = [self permissionBubbleManager];
@@ skipping 444 matching lines @@
   [layout setFullscreenButtonFrame:[self fullscreenButtonFrame]];
 
   if ([self shouldShowAvatar]) {
     NSView* avatar = [avatarButtonController_ view];
     [layout setShouldShowAvatar:YES];
     [layout setShouldUseNewAvatar:[self shouldUseNewAvatarButton]];
     [layout setAvatarSize:[avatar frame].size];
     [layout setAvatarLineWidth:[[avatar superview] cr_lineWidth]];
   }
 
-  [layout setHasToolbar:[self hasToolbar]];
-  [layout setToolbarHeight:NSHeight([[toolbarController_ view] bounds])];
+  if (shouldShowToolbar_) {

[tapted, 2015/09/08 05:55:05]

I think you can read `shouldShowToolbar` by just asking the location bar whether
it's hidden (then would just need to trigger a call to layoutSubviews). But all
that should be irrelevant if we can just collapse the height of the ToolbarView
using AnimatableView.

[dominickn, 2015/10/09 06:37:02]

Done.

+    [layout setHasToolbar:[self hasToolbar]];
+    [layout setToolbarHeight:NSHeight([[toolbarController_ view] bounds])];
+  } else {
+    [layout setHasToolbar:NO];
+    [layout setToolbarHeight:0];
+  }
 
   [layout setHasLocationBar:[self hasLocationBar]];
 
   [layout setPlaceBookmarkBarBelowInfoBar:[self placeBookmarkBarBelowInfoBar]];
   [layout setBookmarkBarHidden:[bookmarkBarController_ view].isHidden];
   [layout setBookmarkBarHeight:
       NSHeight([[bookmarkBarController_ view] bounds])];
 
   [layout setInfoBarHeight:[infoBarContainerController_ heightOfInfoBars]];
   [layout setPageInfoBubblePointY:[self pageInfoBubblePointY]];
@@ skipping 228 matching lines @@
   return browser_->tab_strip_model()->GetActiveWebContents();
 }
 
 - (PermissionBubbleManager*)permissionBubbleManager {
   if (WebContents* contents = [self webContents])
     return PermissionBubbleManager::FromWebContents(contents);
   return nil;
 }
 
 @end  // @implementation BrowserWindowController(Private)