Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1305053002: Fix buildbot console view in order_by_time mode (Closed)

Created:
5 years, 4 months ago by ricow1
Modified:
5 years, 3 months ago
Reviewers:
agable
CC:
chromium-reviews, infra-reviews+build_chromium.org, kustermann
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix buildbot console view in order_by_time mode Applying a rebased version of http://trac.buildbot.net/ticket/2364 R=agable@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296438

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -6 lines) Patch
M third_party/buildbot_8_4p1/README.chromium View 1 1 chunk +81 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/console.py View 7 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
ricow1
Aaron, randomly picked you from log. I hope this is the right approach for landing ...
5 years, 4 months ago (2015-08-21 11:30:02 UTC) #1
agable
LGTM, yep this is the right approach to merging in changes from the buildbot project ...
5 years, 4 months ago (2015-08-25 18:21:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305053002/1
5 years, 3 months ago (2015-08-26 05:14:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1315)
5 years, 3 months ago (2015-08-26 05:16:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305053002/20001
5 years, 3 months ago (2015-08-26 09:17:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296438
5 years, 3 months ago (2015-08-26 09:20:22 UTC) #10
msw
On 2015/08/26 09:20:22, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
5 years, 3 months ago (2015-08-26 23:35:47 UTC) #11
agable
On 2015/08/26 at 23:35:47, msw wrote: > On 2015/08/26 09:20:22, commit-bot: I haz the power ...
5 years, 3 months ago (2015-08-26 23:48:26 UTC) #12
msw
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1310303005/ by msw@chromium.org. ...
5 years, 3 months ago (2015-08-26 23:49:29 UTC) #13
agable
On 2015/08/26 at 23:48:26, agable wrote: > On 2015/08/26 at 23:35:47, msw wrote: > > ...
5 years, 3 months ago (2015-08-26 23:55:07 UTC) #14
agable
5 years, 3 months ago (2015-08-26 23:57:35 UTC) #15
Message was sent while issue was closed.
Thanks for the revert; I've updated my fix to be a reland+fix.

Powered by Google App Engine
This is Rietveld 408576698