Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1309253003: Reland "Fix buildbot console view in order_by_time mode" (Closed)

Created:
5 years, 3 months ago by agable
Modified:
5 years, 3 months ago
Reviewers:
ricow1, msw, Rico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland "Fix buildbot console view in order_by_time mode" Applying a rebased version of http://trac.buildbot.net/ticket/2364, plus a fix for chromium_status_bb8 R=msw@chromium.org, ricow@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296449

Patch Set 1 #

Patch Set 2 : Reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -13 lines) Patch
M scripts/master/chromium_status_bb8.py View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/buildbot_8_4p1/README.chromium View 1 1 chunk +81 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/console.py View 1 7 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
agable
5 years, 3 months ago (2015-08-26 23:54:58 UTC) #1
msw
Ah, I already reverted the CL, you'll need to re-land it.
5 years, 3 months ago (2015-08-26 23:57:21 UTC) #2
agable
On 2015/08/26 at 23:57:21, msw wrote: > Ah, I already reverted the CL, you'll need ...
5 years, 3 months ago (2015-08-26 23:58:17 UTC) #3
msw
Rubber stamp lgtm; the diff from the original CL looks right.
5 years, 3 months ago (2015-08-26 23:59:35 UTC) #4
agable
On 2015/08/26 at 23:59:35, msw wrote: > Rubber stamp lgtm; the diff from the original ...
5 years, 3 months ago (2015-08-27 00:00:11 UTC) #5
ricow1
lgtm, thank you - and sorry about that.
5 years, 3 months ago (2015-08-27 05:34:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309253003/20001
5 years, 3 months ago (2015-08-27 05:34:39 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 05:37:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296449

Powered by Google App Engine
This is Rietveld 408576698