chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 1305043003: Unncessary 'View source code' option is enabled in context menu of the 'Pdf Viewer' app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1305043003: Unncessary 'View source code' option is enabled in context menu of the 'Pdf Viewer' app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index e7b57ee9ec29b050e78c5c5b519e5f7d9eddf515..9b1d5711f02c906c8e3b91231eb03bf4a32077a6 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -1146,6 +1146,8 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {

case IDC_VIEW_SOURCE:

case IDC_CONTENT_CONTEXT_VIEWFRAMESOURCE:

+ if (params_.media_type == WebContextMenuData::MediaTypePlugin)

+ return false;

return embedder_web_contents_->GetController().CanViewSource();

Peter Kasting 2015/09/05 20:42:51 Nit: Simpler: return (params_.media_type !=

Deepak 2015/09/07 03:00:41 Done.

case IDC_CONTENT_CONTEXT_INSPECTELEMENT:

« no previous file with comments | « no previous file | no next file » | no next file with comments »