Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1305043003: Unncessary 'View source code' option is enabled in context menu of the 'Pdf Viewer' app. (Closed)

Created:
5 years, 4 months ago by Deepak
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unncessary 'View source code' option is enabled in context menu of the 'Pdf Viewer' app. If we're viewing in a MimeHandlerViewGuest, that is we have plugin , view source should not be shown. BUG=523254 Committed: https://crrev.com/467ac7794852a11645ef172205d9a668c84523fd Cr-Commit-Position: refs/heads/master@{#347598}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes as per review comments. #

Patch Set 3 : Change for new approach. #

Total comments: 6

Patch Set 4 : Changes as per review comments. #

Total comments: 2

Patch Set 5 : Changes as per review comments #

Total comments: 2

Patch Set 6 : Changes as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 28 (6 generated)
Deepak
PTAL at this small change. Thanks
5 years, 4 months ago (2015-08-23 05:58:50 UTC) #2
Deepak
PTAL at this small change. Thanks
5 years, 4 months ago (2015-08-25 12:40:51 UTC) #3
Deepak
@avi PTAL at this small change. Thanks
5 years, 3 months ago (2015-09-01 02:50:13 UTC) #5
Avi (use Gerrit)
I think this is OK. Does this prevent "view source" for any <webview>? https://codereview.chromium.org/1305043003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File ...
5 years, 3 months ago (2015-09-01 04:06:12 UTC) #6
Deepak
Thanks for review. This will prevent "view source" for app's that have no browser associated. ...
5 years, 3 months ago (2015-09-01 05:24:59 UTC) #7
Deepak
@avi PTAL, Thanks
5 years, 3 months ago (2015-09-03 15:05:41 UTC) #8
Avi (use Gerrit)
I'm trying to understand how this regressed. The call to the embedder's CanViewSource ends up ...
5 years, 3 months ago (2015-09-03 15:13:40 UTC) #9
Avi (use Gerrit)
On 2015/09/03 15:13:40, Avi wrote: > I'm trying to understand how this regressed. The call ...
5 years, 3 months ago (2015-09-03 19:32:40 UTC) #10
Deepak
On 2015/09/03 19:32:40, Avi wrote: > On 2015/09/03 15:13:40, Avi wrote: > > I'm trying ...
5 years, 3 months ago (2015-09-04 05:45:50 UTC) #11
Avi (use Gerrit)
On 2015/09/04 05:45:50, Deepak wrote: > 1) In issue We are getting mime_type as "text/html" ...
5 years, 3 months ago (2015-09-04 15:39:23 UTC) #12
Deepak
On 2015/09/04 15:39:23, Avi wrote: > On 2015/09/04 05:45:50, Deepak wrote: > > 1) In ...
5 years, 3 months ago (2015-09-05 08:04:49 UTC) #13
AKV
Please check inline comments. https://codereview.chromium.org/1305043003/diff/40001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1305043003/diff/40001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1149 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1149: // If we're viewing in ...
5 years, 3 months ago (2015-09-05 11:15:32 UTC) #15
Deepak
@AKV PTAL https://codereview.chromium.org/1305043003/diff/40001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1305043003/diff/40001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1149 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1149: // If we're viewing in a MimeHandlerViewGuest ...
5 years, 3 months ago (2015-09-05 11:52:15 UTC) #16
AKV
Please check inline comment. https://codereview.chromium.org/1305043003/diff/60001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1305043003/diff/60001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1151 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1151: if (extensions::MimeHandlerViewGuest::FromWebContents( Can we use ...
5 years, 3 months ago (2015-09-05 12:53:10 UTC) #17
Deepak
@AKV PTAL https://codereview.chromium.org/1305043003/diff/60001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1305043003/diff/60001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1151 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1151: if (extensions::MimeHandlerViewGuest::FromWebContents( On 2015/09/05 12:53:09, AKV wrote: ...
5 years, 3 months ago (2015-09-05 12:55:08 UTC) #18
AKV
peer review looks good to me!
5 years, 3 months ago (2015-09-05 13:12:48 UTC) #19
Avi (use Gerrit)
lgtm That actually looks like a really good way to do this. Thanks Ajith for ...
5 years, 3 months ago (2015-09-05 20:29:14 UTC) #20
Peter Kasting
Drive-by (no signoff from me needed) https://codereview.chromium.org/1305043003/diff/80001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1305043003/diff/80001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1151 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1151: return embedder_web_contents_->GetController().CanViewSource(); Nit: ...
5 years, 3 months ago (2015-09-05 20:42:51 UTC) #22
Deepak
Thanks @peter for review. Changes done as suggested. Thanks https://codereview.chromium.org/1305043003/diff/80001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1305043003/diff/80001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1151 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1151: ...
5 years, 3 months ago (2015-09-07 03:00:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305043003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305043003/100001
5 years, 3 months ago (2015-09-07 03:00:53 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-07 03:43:41 UTC) #27
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 03:44:18 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/467ac7794852a11645ef172205d9a668c84523fd
Cr-Commit-Position: refs/heads/master@{#347598}

Powered by Google App Engine
This is Rietveld 408576698