Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305023003: Return const by ref instead of value (Closed)

Created:
5 years, 4 months ago by tanay.c
Modified:
5 years, 3 months ago
Reviewers:
eroman, gavinp
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return const by ref instead of value BUG=393155 Committed: https://crrev.com/6ddd5f6f759f3858f89bf4abdb4c101b726edf61 Cr-Commit-Position: refs/heads/master@{#345273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M net/dns/host_resolver_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tanay.c
PTAL
5 years, 4 months ago (2015-08-21 11:29:19 UTC) #2
tanay.c
PTAL
5 years, 4 months ago (2015-08-21 11:31:48 UTC) #4
eroman
lgtm
5 years, 4 months ago (2015-08-21 19:04:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305023003/1
5 years, 3 months ago (2015-08-25 05:24:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-25 06:35:04 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 06:35:49 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ddd5f6f759f3858f89bf4abdb4c101b726edf61
Cr-Commit-Position: refs/heads/master@{#345273}

Powered by Google App Engine
This is Rietveld 408576698