net/dns/host_resolver_impl.cc - Issue 1305023003: Return const by ref instead of value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl.cc

Issue 1305023003: Return const by ref instead of value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/host_resolver_impl.cc

diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc

index d3f83655356922b58551ca13adbec1bf14c157d5..179b3fcdbcebd79bf0bed85aeaf80fb5d392b4d8 100644

--- a/net/dns/host_resolver_impl.cc

+++ b/net/dns/host_resolver_impl.cc

@@ -1417,9 +1417,7 @@ class HostResolverImpl::Job : public PrioritizedDispatcher::Job,

return false;

}

- const Key key() const {

- return key_;

- }

+ const Key& key() const { return key_; }

bool is_queued() const {

return !handle_.is_null();

« no previous file with comments | « no previous file | no next file » | no next file with comments »