Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1304923003: [arm64] Don't try convert binary operation to shifted form when both operands are the same. (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Don't try convert binary operation to shifted form when both operands are the same. BUG=chromium:523307 LOG=N Committed: https://crrev.com/85f6e1684447a728b51e8b7a56746e5bad781d4a Cr-Commit-Position: refs/heads/master@{#30538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/arm64/lithium-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-523307.js View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 3 months ago (2015-09-01 11:16:19 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-02 06:43:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304923003/1
5 years, 3 months ago (2015-09-02 08:28:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 09:32:40 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 09:32:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85f6e1684447a728b51e8b7a56746e5bad781d4a
Cr-Commit-Position: refs/heads/master@{#30538}

Powered by Google App Engine
This is Rietveld 408576698