src/arm64/lithium-arm64.cc - Issue 1304923003: [arm64] Don't try convert binary operation to shifted form when both operands are the same.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-arm64.cc

Issue 1304923003: [arm64] Don't try convert binary operation to shifted form when both operands are the same. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/lithium-arm64.cc

diff --git a/src/arm64/lithium-arm64.cc b/src/arm64/lithium-arm64.cc

index bdf49bfff009e94a0c66c33bd7c30ac5d940fb6b..63ae4214ffc7283759c52d825cb4defe57b5e456 100644

--- a/src/arm64/lithium-arm64.cc

+++ b/src/arm64/lithium-arm64.cc

@@ -2132,6 +2132,8 @@ HBitwiseBinaryOperation* LChunkBuilder::CanTransformToShiftedOp(HValue* val,

DCHECK(hleft->representation().Equals(hinstr->representation()));

DCHECK(hright->representation().Equals(hinstr->representation()));

+ if (hleft == hright) return NULL;

if ((hright->IsConstant() &&

LikelyFitsImmField(hinstr, HConstant::cast(hright)->Integer32Value())) ||

(hinstr->IsCommutative() && hleft->IsConstant() &&

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-523307.js » ('j') | no next file with comments »