ui/file_manager/file_manager/foreground/js/sort_menu_controller.js - Issue 1304883005: Make |context| passed to queryRequiredElement optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/sort_menu_controller.js

Issue 1304883005: Make |context| passed to queryRequiredElement optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whoops Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/import_controller.js ('k') | ui/file_manager/file_manager/foreground/js/toolbar_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/sort_menu_controller.js

diff --git a/ui/file_manager/file_manager/foreground/js/sort_menu_controller.js b/ui/file_manager/file_manager/foreground/js/sort_menu_controller.js

index f9123bc5e4bd072b9c25b9f4c3afdc032f09bdd0..ba4327bb231302a0cdddb16a3acc8fbfa488b5a6 100644

--- a/ui/file_manager/file_manager/foreground/js/sort_menu_controller.js

+++ b/ui/file_manager/file_manager/foreground/js/sort_menu_controller.js

@@ -18,16 +18,16 @@ function SortMenuController(sortButton, toggleRipple, fileListModel) {

/** @private {!HTMLElement} */

this.sortByNameButton_ = queryRequiredElement(

- sortButton.menu, '#sort-menu-sort-by-name');

+ '#sort-menu-sort-by-name', sortButton.menu);

/** @private {!HTMLElement} */

this.sortBySizeButton_ = queryRequiredElement(

- sortButton.menu, '#sort-menu-sort-by-size');

+ '#sort-menu-sort-by-size', sortButton.menu);

/** @private {!HTMLElement} */

this.sortByTypeButton_ = queryRequiredElement(

- sortButton.menu, '#sort-menu-sort-by-type');

+ '#sort-menu-sort-by-type', sortButton.menu);

/** @private {!HTMLElement} */

this.sortByDateButton_ = queryRequiredElement(

- sortButton.menu, '#sort-menu-sort-by-date');

+ '#sort-menu-sort-by-date', sortButton.menu);

sortButton.addEventListener('menushow', this.updateCheckmark_.bind(this));

sortButton.addEventListener('menuhide', this.onHideSortMenu_.bind(this));