Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: ui/file_manager/file_manager/foreground/js/import_controller.js

Issue 1304883005: Make |context| passed to queryRequiredElement optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whoops Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/import_controller.js
diff --git a/ui/file_manager/file_manager/foreground/js/import_controller.js b/ui/file_manager/file_manager/foreground/js/import_controller.js
index 9b4d0c6d87e88880767f9e5465219ca649732704..3e06bfe0d62e0a5a4df0002b3590aa5c619d92e5 100644
--- a/ui/file_manager/file_manager/foreground/js/import_controller.js
+++ b/ui/file_manager/file_manager/foreground/js/import_controller.js
@@ -534,30 +534,29 @@ importer.RuntimeCommandWidget = function() {
};
/** @private {!Element} */
- this.comboButton_ = queryRequiredElement(
- document, '#cloud-import-combo-button');
+ this.comboButton_ = getRequiredElement('cloud-import-combo-button');
/** @private {!Element} */
this.mainButton_ = queryRequiredElement(
- this.comboButton_, '#cloud-import-button');
+ '#cloud-import-button', this.comboButton_);
this.mainButton_.onclick = this.onButtonClicked_.bind(
this, importer.ClickSource.MAIN);
/** @private {!PaperRipple}*/
this.mainButtonRipple_ =
/** @type {!PaperRipple} */ (queryRequiredElement(
- this.comboButton_, '.ripples > paper-ripple'));
+ '.ripples > paper-ripple', this.comboButton_));
/** @private {Element} */
this.sideButton_ = queryRequiredElement(
- this.comboButton_, '#cloud-import-details-button');
+ '#cloud-import-details-button', this.comboButton_);
this.sideButton_.onclick = this.onButtonClicked_.bind(
this, importer.ClickSource.SIDE);
/** @private {!FilesToggleRipple} */
this.sideButtonRipple_ =
/** @type {!FilesToggleRipple} */ (queryRequiredElement(
- this.comboButton_, '.ripples > files-toggle-ripple'));
+ '.ripples > files-toggle-ripple', this.comboButton_));
/** @private {Element} */
this.importButton_ =

Powered by Google App Engine
This is Rietveld 408576698