chrome/browser/download/download_dir_policy_handler_unittest.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_dir_policy_handler_unittest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed another test. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/system/tray_accessibility_browsertest.cc ('k') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_dir_policy_handler_unittest.cc

diff --git a/chrome/browser/download/download_dir_policy_handler_unittest.cc b/chrome/browser/download/download_dir_policy_handler_unittest.cc

index c0ad58692a79ed7c39738a091d4392f4adc424c7..d713ba7bcef37cdb1fff827a1acb41d247bbb0d8 100644

--- a/chrome/browser/download/download_dir_policy_handler_unittest.cc

+++ b/chrome/browser/download/download_dir_policy_handler_unittest.cc

@@ -72,6 +72,7 @@ TEST_F(DownloadDirPolicyHandlerTest, SetDownloadDirectory) {

policy.Set(policy::key::kDownloadDirectory,

policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER,

+ policy::POLICY_SOURCE_CLOUD,

new base::StringValue(std::string()),

NULL);

UpdateProviderPolicy(policy);

@@ -95,6 +96,7 @@ TEST_F(DownloadDirPolicyHandlerTest, SetDownloadToDrive) {

policy.Set(policy::key::kDownloadDirectory,

policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER,

+ policy::POLICY_SOURCE_CLOUD,

new base::StringValue(kDriveNamePolicyVariableName),

NULL);

UpdateProviderPolicy(policy);

@@ -121,6 +123,7 @@ TEST_F(DownloadDirPolicyHandlerTest, SetDownloadToDrive) {

policy.Set(policy::key::kDownloadDirectory,

policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER,

+ policy::POLICY_SOURCE_CLOUD,

new base::StringValue(kUserIDHash),

NULL);

UpdateProviderPolicy(policy);

@@ -129,6 +132,7 @@ TEST_F(DownloadDirPolicyHandlerTest, SetDownloadToDrive) {

policy.Set(policy::key::kDownloadDirectory,

policy::POLICY_LEVEL_RECOMMENDED,

policy::POLICY_SCOPE_USER,

+ policy::POLICY_SOURCE_CLOUD,

new base::StringValue(std::string(kDriveNamePolicyVariableName) +

kRelativeToDriveRoot),

NULL);

@@ -147,6 +151,7 @@ TEST_F(DownloadDirPolicyHandlerTest, SetDownloadToDrive) {

policy.Set(policy::key::kDownloadDirectory,

policy::POLICY_LEVEL_RECOMMENDED,

policy::POLICY_SCOPE_USER,

+ policy::POLICY_SOURCE_CLOUD,

new base::StringValue(kUserIDHash),

NULL);

UpdateProviderPolicy(policy);