Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/download/download_dir_policy_handler_unittest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed another test. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/download/download_dir_policy_handler.h" 10 #include "chrome/browser/download/download_dir_policy_handler.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 scoped_refptr<policy::ConfigurationPolicyPrefStore> recommended_store_; 65 scoped_refptr<policy::ConfigurationPolicyPrefStore> recommended_store_;
66 }; 66 };
67 67
68 #if !defined(OS_CHROMEOS) 68 #if !defined(OS_CHROMEOS)
69 TEST_F(DownloadDirPolicyHandlerTest, SetDownloadDirectory) { 69 TEST_F(DownloadDirPolicyHandlerTest, SetDownloadDirectory) {
70 policy::PolicyMap policy; 70 policy::PolicyMap policy;
71 EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL)); 71 EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
72 policy.Set(policy::key::kDownloadDirectory, 72 policy.Set(policy::key::kDownloadDirectory,
73 policy::POLICY_LEVEL_MANDATORY, 73 policy::POLICY_LEVEL_MANDATORY,
74 policy::POLICY_SCOPE_USER, 74 policy::POLICY_SCOPE_USER,
75 policy::POLICY_SOURCE_CLOUD,
75 new base::StringValue(std::string()), 76 new base::StringValue(std::string()),
76 NULL); 77 NULL);
77 UpdateProviderPolicy(policy); 78 UpdateProviderPolicy(policy);
78 79
79 // Setting a DownloadDirectory should disable the PromptForDownload pref. 80 // Setting a DownloadDirectory should disable the PromptForDownload pref.
80 const base::Value* value = NULL; 81 const base::Value* value = NULL;
81 EXPECT_TRUE(store_->GetValue(prefs::kPromptForDownload, &value)); 82 EXPECT_TRUE(store_->GetValue(prefs::kPromptForDownload, &value));
82 ASSERT_TRUE(value); 83 ASSERT_TRUE(value);
83 bool prompt_for_download = true; 84 bool prompt_for_download = true;
84 bool result = value->GetAsBoolean(&prompt_for_download); 85 bool result = value->GetAsBoolean(&prompt_for_download);
85 ASSERT_TRUE(result); 86 ASSERT_TRUE(result);
86 EXPECT_FALSE(prompt_for_download); 87 EXPECT_FALSE(prompt_for_download);
87 } 88 }
88 #endif 89 #endif
89 90
90 #if defined(OS_CHROMEOS) 91 #if defined(OS_CHROMEOS)
91 TEST_F(DownloadDirPolicyHandlerTest, SetDownloadToDrive) { 92 TEST_F(DownloadDirPolicyHandlerTest, SetDownloadToDrive) {
92 EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL)); 93 EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
93 94
94 policy::PolicyMap policy; 95 policy::PolicyMap policy;
95 policy.Set(policy::key::kDownloadDirectory, 96 policy.Set(policy::key::kDownloadDirectory,
96 policy::POLICY_LEVEL_MANDATORY, 97 policy::POLICY_LEVEL_MANDATORY,
97 policy::POLICY_SCOPE_USER, 98 policy::POLICY_SCOPE_USER,
99 policy::POLICY_SOURCE_CLOUD,
98 new base::StringValue(kDriveNamePolicyVariableName), 100 new base::StringValue(kDriveNamePolicyVariableName),
99 NULL); 101 NULL);
100 UpdateProviderPolicy(policy); 102 UpdateProviderPolicy(policy);
101 103
102 const base::Value* value = NULL; 104 const base::Value* value = NULL;
103 bool prompt_for_download; 105 bool prompt_for_download;
104 EXPECT_TRUE(store_->GetValue(prefs::kPromptForDownload, &value)); 106 EXPECT_TRUE(store_->GetValue(prefs::kPromptForDownload, &value));
105 EXPECT_TRUE(value); 107 EXPECT_TRUE(value);
106 EXPECT_TRUE(value->GetAsBoolean(&prompt_for_download)); 108 EXPECT_TRUE(value->GetAsBoolean(&prompt_for_download));
107 EXPECT_FALSE(prompt_for_download); 109 EXPECT_FALSE(prompt_for_download);
108 110
109 bool disable_drive; 111 bool disable_drive;
110 EXPECT_TRUE(store_->GetValue(drive::prefs::kDisableDrive, &value)); 112 EXPECT_TRUE(store_->GetValue(drive::prefs::kDisableDrive, &value));
111 EXPECT_TRUE(value); 113 EXPECT_TRUE(value);
112 EXPECT_TRUE(value->GetAsBoolean(&disable_drive)); 114 EXPECT_TRUE(value->GetAsBoolean(&disable_drive));
113 EXPECT_FALSE(disable_drive); 115 EXPECT_FALSE(disable_drive);
114 116
115 std::string download_directory; 117 std::string download_directory;
116 EXPECT_TRUE(store_->GetValue(prefs::kDownloadDefaultDirectory, &value)); 118 EXPECT_TRUE(store_->GetValue(prefs::kDownloadDefaultDirectory, &value));
117 EXPECT_TRUE(value); 119 EXPECT_TRUE(value);
118 EXPECT_TRUE(value->GetAsString(&download_directory)); 120 EXPECT_TRUE(value->GetAsString(&download_directory));
119 EXPECT_EQ(GetExpectedDownloadDirectory(), download_directory); 121 EXPECT_EQ(GetExpectedDownloadDirectory(), download_directory);
120 122
121 policy.Set(policy::key::kDownloadDirectory, 123 policy.Set(policy::key::kDownloadDirectory,
122 policy::POLICY_LEVEL_MANDATORY, 124 policy::POLICY_LEVEL_MANDATORY,
123 policy::POLICY_SCOPE_USER, 125 policy::POLICY_SCOPE_USER,
126 policy::POLICY_SOURCE_CLOUD,
124 new base::StringValue(kUserIDHash), 127 new base::StringValue(kUserIDHash),
125 NULL); 128 NULL);
126 UpdateProviderPolicy(policy); 129 UpdateProviderPolicy(policy);
127 EXPECT_FALSE(recommended_store_->GetValue(drive::prefs::kDisableDrive, NULL)); 130 EXPECT_FALSE(recommended_store_->GetValue(drive::prefs::kDisableDrive, NULL));
128 131
129 policy.Set(policy::key::kDownloadDirectory, 132 policy.Set(policy::key::kDownloadDirectory,
130 policy::POLICY_LEVEL_RECOMMENDED, 133 policy::POLICY_LEVEL_RECOMMENDED,
131 policy::POLICY_SCOPE_USER, 134 policy::POLICY_SCOPE_USER,
135 policy::POLICY_SOURCE_CLOUD,
132 new base::StringValue(std::string(kDriveNamePolicyVariableName) + 136 new base::StringValue(std::string(kDriveNamePolicyVariableName) +
133 kRelativeToDriveRoot), 137 kRelativeToDriveRoot),
134 NULL); 138 NULL);
135 UpdateProviderPolicy(policy); 139 UpdateProviderPolicy(policy);
136 140
137 EXPECT_FALSE(recommended_store_->GetValue(prefs::kPromptForDownload, NULL)); 141 EXPECT_FALSE(recommended_store_->GetValue(prefs::kPromptForDownload, NULL));
138 EXPECT_FALSE(recommended_store_->GetValue(drive::prefs::kDisableDrive, NULL)); 142 EXPECT_FALSE(recommended_store_->GetValue(drive::prefs::kDisableDrive, NULL));
139 143
140 EXPECT_TRUE( 144 EXPECT_TRUE(
141 recommended_store_->GetValue(prefs::kDownloadDefaultDirectory, &value)); 145 recommended_store_->GetValue(prefs::kDownloadDefaultDirectory, &value));
142 EXPECT_TRUE(value); 146 EXPECT_TRUE(value);
143 EXPECT_TRUE(value->GetAsString(&download_directory)); 147 EXPECT_TRUE(value->GetAsString(&download_directory));
144 EXPECT_EQ(GetExpectedDownloadDirectory() + kRelativeToDriveRoot, 148 EXPECT_EQ(GetExpectedDownloadDirectory() + kRelativeToDriveRoot,
145 download_directory); 149 download_directory);
146 150
147 policy.Set(policy::key::kDownloadDirectory, 151 policy.Set(policy::key::kDownloadDirectory,
148 policy::POLICY_LEVEL_RECOMMENDED, 152 policy::POLICY_LEVEL_RECOMMENDED,
149 policy::POLICY_SCOPE_USER, 153 policy::POLICY_SCOPE_USER,
154 policy::POLICY_SOURCE_CLOUD,
150 new base::StringValue(kUserIDHash), 155 new base::StringValue(kUserIDHash),
151 NULL); 156 NULL);
152 UpdateProviderPolicy(policy); 157 UpdateProviderPolicy(policy);
153 158
154 EXPECT_FALSE(recommended_store_->GetValue(prefs::kPromptForDownload, NULL)); 159 EXPECT_FALSE(recommended_store_->GetValue(prefs::kPromptForDownload, NULL));
155 EXPECT_FALSE(recommended_store_->GetValue(drive::prefs::kDisableDrive, NULL)); 160 EXPECT_FALSE(recommended_store_->GetValue(drive::prefs::kDisableDrive, NULL));
156 161
157 EXPECT_TRUE( 162 EXPECT_TRUE(
158 recommended_store_->GetValue(prefs::kDownloadDefaultDirectory, &value)); 163 recommended_store_->GetValue(prefs::kDownloadDefaultDirectory, &value));
159 EXPECT_TRUE(value); 164 EXPECT_TRUE(value);
160 EXPECT_TRUE(value->GetAsString(&download_directory)); 165 EXPECT_TRUE(value->GetAsString(&download_directory));
161 EXPECT_EQ(kUserIDHash, download_directory); 166 EXPECT_EQ(kUserIDHash, download_directory);
162 } 167 }
163 #endif 168 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698