Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: components/policy/core/common/async_policy_loader.h

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed browsertest and removed unnecessary string for default values. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/async_policy_loader.h
diff --git a/components/policy/core/common/async_policy_loader.h b/components/policy/core/common/async_policy_loader.h
index 16437a87f2ce3543e115351ea33e46be856e5375..047b9106cdc9ab7c6e19115c52d0fa87098b4505 100644
--- a/components/policy/core/common/async_policy_loader.h
+++ b/components/policy/core/common/async_policy_loader.h
@@ -10,6 +10,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
+#include "components/policy/core/common/policy_types.h"
Thiemo Nagel 2015/09/01 17:40:36 Don't include header files when it can be prevente
fhorschig 2015/09/04 06:53:53 Done.
#include "components/policy/core/common/schema_map.h"
#include "components/policy/policy_export.h"
@@ -49,6 +50,9 @@ class POLICY_EXPORT AsyncPolicyLoader {
// thread (e.g. setup file watchers).
virtual void InitOnBackgroundThread() = 0;
+ // Provides the source of the policies for providers.
+ virtual PolicySource source() const = 0;
Thiemo Nagel 2015/09/01 17:40:36 Please add a source_ member and make this a non-ab
fhorschig 2015/09/04 06:53:54 Done. (Not even necessary. Loaders are always of p
+
// Implementations should return the time of the last modification detected,
// or base::Time() if it doesn't apply, which is the default.
virtual base::Time LastModificationTime();

Powered by Google App Engine
This is Rietveld 408576698