Add source column to chrome://policy showing the origins of policies.

components/policy/core/common/async_policy_loader.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_COMMON_ASYNC_POLICY_LOADER_H_
 #define COMPONENTS_POLICY_CORE_COMMON_ASYNC_POLICY_LOADER_H_
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
+#include "components/policy/core/common/policy_types.h"

[Thiemo Nagel, 2015/09/01 17:40:36]

Don't include header files when it can be prevented by a forward declaration.

[fhorschig, 2015/09/04 06:53:53]

Done.

 #include "components/policy/core/common/schema_map.h"
 #include "components/policy/policy_export.h"
 
 namespace base {
 class SequencedTaskRunner;
 }
 
 namespace policy {
 
 class PolicyBundle;
@@ skipping 19 matching lines @@
 
   // Returns the currently configured policies. Load() is always invoked on
   // the background thread, except for the initial Load() at startup which is
   // invoked from the thread that owns the provider.
   virtual scoped_ptr<PolicyBundle> Load() = 0;
 
   // Allows implementations to finalize their initialization on the background
   // thread (e.g. setup file watchers).
   virtual void InitOnBackgroundThread() = 0;
 
+  // Provides the source of the policies for providers.
+  virtual PolicySource source() const = 0;

[Thiemo Nagel, 2015/09/01 17:40:36]

Please add a source_ member and make this a non-abstract member function.

[fhorschig, 2015/09/04 06:53:54]

Done. (Not even necessary. Loaders are always of platform type.)

+
   // Implementations should return the time of the last modification detected,
   // or base::Time() if it doesn't apply, which is the default.
   virtual base::Time LastModificationTime();
 
   // Used by the AsyncPolicyProvider to do the initial Load(). The first load
   // is also used to initialize |last_modification_time_| and
   // |schema_map_|.
   scoped_ptr<PolicyBundle> InitialLoad(const scoped_refptr<SchemaMap>& schemas);
 
   // Implementations should invoke Reload() when a change is detected. This
@@ skipping 51 matching lines @@
 
   // Used to get WeakPtrs for the periodic reload task.
   base::WeakPtrFactory<AsyncPolicyLoader> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AsyncPolicyLoader);
 };
 
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_COMMON_ASYNC_POLICY_LOADER_H_