chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc ('K') | « chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc ('k') | chrome/browser/chromeos/policy/device_local_account_policy_provider.cc » ('j') | chrome/browser/chromeos/policy/device_local_account_policy_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

index 7072f2da6c32a29f228505903e843eb6e5023c69..715af9a75729d892ae6540f90ac7c52aae7f2754 100644

--- a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

+++ b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

@@ -181,11 +181,12 @@ class DeviceCloudPolicyManagerChromeOSTest

void VerifyPolicyPopulated() {

PolicyBundle bundle;

bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))

- .Set(key::kDeviceMetricsReportingEnabled,

- POLICY_LEVEL_MANDATORY,

- POLICY_SCOPE_MACHINE,

- new base::FundamentalValue(false),

- NULL);

+ .SetWithSource(key::kDeviceMetricsReportingEnabled,

+ POLICY_LEVEL_MANDATORY,

+ POLICY_SCOPE_MACHINE,

+ new base::FundamentalValue(false),

+ NULL,

bartfab (slow) 2015/09/14 14:42:25 Nit: s/NULL/nullptr/

fhorschig 2015/09/16 13:52:03 Done.

+ POLICY_SOURCE_CLOUD);

bartfab (slow) 2015/09/14 14:42:25 Nit: #include "components/policy/core/common/polic

fhorschig 2015/09/16 13:52:03 Done.

EXPECT_TRUE(manager_->policies().Equals(bundle));

}