chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc - Issue 1304843004: Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

Issue 1304843004: Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc » ('j') | chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

index 7c304434a1ea1c9b78746a1904e5c38120a43136..f9d7020b40d2f1bbbb8c7d8c2e3967141145b9cd 100644

--- a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

+++ b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc

@@ -265,8 +265,12 @@ void NetworkConfigurationPolicyHandler::PrepareForDisplaying(

if (!sanitized_config)

sanitized_config = base::Value::CreateNullValue().release();

- policies->Set(policy_name(), entry->level, entry->scope,

- sanitized_config, NULL);

+ policies->SetWithSource(policy_name(),

+ entry->level,

+ entry->scope,

+ sanitized_config,

+ NULL,

bartfab (slow) 2015/09/14 14:42:25 Nit: s/NULL/nullptr/

fhorschig 2015/09/16 13:52:03 Done.

+ entry->source);

}

NetworkConfigurationPolicyHandler::NetworkConfigurationPolicyHandler(