Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1304723002: [PushMessaging] Use appopriate type parameters for WebCallbacks (1/3). (Closed)

Created:
5 years, 4 months ago by yhirano
Modified:
5 years, 4 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, johnme+watch_chromium.org, dglazkov+blink, peter+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[PushMessaging] Use appopriate type parameters for WebCallbacks (1/3). This series of CLs fixes WebCallback parameter types used in PushMessaging. - WebPushSubscription* (ownership transferred) => PassOwnPtr<WebPushSubscription> - WebPushPermissionStatus* (ownership not transferred) => WebPushPermissionStatus - WebPushError* (ownership transferred) => const WebPushError& 1/3: https://codereview.chromium.org/1304723002/ 2/3: https://codereview.chromium.org/1291023005/ 3/3: https://codereview.chromium.org/1302833004/ BUG=493531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200923

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -30 lines) Patch
M Source/modules/push_messaging/PushPermissionStatusCallbacks.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushSubscription.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/push_messaging/PushSubscriptionCallbacks.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/push_messaging/PushSubscriptionCallbacks.cpp View 1 2 chunks +5 lines, -9 lines 0 comments Download
M public/platform/modules/push_messaging/WebPushClient.h View 2 chunks +1 line, -2 lines 0 comments Download
M public/platform/modules/push_messaging/WebPushProvider.h View 1 chunk +31 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yhirano
5 years, 4 months ago (2015-08-20 06:19:17 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 4 months ago (2015-08-20 13:32:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304723002/20001
5 years, 4 months ago (2015-08-20 17:07:50 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 19:15:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200923

Powered by Google App Engine
This is Rietveld 408576698