Source/modules/push_messaging/PushSubscription.h - Issue 1304723002: [PushMessaging] Use appopriate type parameters for WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushSubscription.h

Issue 1304723002: [PushMessaging] Use appopriate type parameters for WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/push_messaging/PushSubscription.h

diff --git a/Source/modules/push_messaging/PushSubscription.h b/Source/modules/push_messaging/PushSubscription.h

index d9de3ea76c7eb18de5fde3afbf689678bf875268..f16330562d3b0ec98ef0e12ea58b8cb9f69f6a41 100644

--- a/Source/modules/push_messaging/PushSubscription.h

+++ b/Source/modules/push_messaging/PushSubscription.h

@@ -24,7 +24,7 @@ struct WebPushSubscription;

class PushSubscription final : public GarbageCollectedFinalized<PushSubscription>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

- static PushSubscription* take(ScriptPromiseResolver*, WebPushSubscription*, ServiceWorkerRegistration*);

+ static PushSubscription* take(ScriptPromiseResolver*, PassOwnPtr<WebPushSubscription>, ServiceWorkerRegistration*);

static void dispose(WebPushSubscription* subscriptionRaw);

virtual ~PushSubscription();