Correctify instanceof and make it optimizable.

Correctify instanceof and make it optimizable.

The previous hack with HInstanceOfKnownGlobal was not only slower,
but also very brittle and required a lot of weird hacks to support it. And
what's even more important it wasn't even correct (because a map check
on the lhs is never enough for instanceof).

The new implementation provides a sane runtime implementation
for InstanceOf plus a fast case in the InstanceOfStub, combined with
a proper specialization in the case of a known global in CrankShaft,
which does only the prototype chain walk (coupled with a code
dependency on the known global).

As a drive-by-fix: Also fix the incorrect Object.prototype.isPrototypeOf
implementation.

BUG=v8:4376
LOG=y

Committed: https://crrev.com/5d875a57fa2e65c1a4a6b50aeb23c38299c3cfbc
Cr-Commit-Position: refs/heads/master@{#30342}

[Benedikt Meurer, 2015-08-21 10:24:11]

Patchset #8 (id:140001) has been deleted

[Benedikt Meurer, 2015-08-21 10:24:17]

Patchset #1 (id:1) has been deleted

[Benedikt Meurer, 2015-08-21 10:24:25]

Patchset #1 (id:20001) has been deleted

[Benedikt Meurer, 2015-08-21 10:24:49]

Patchset #1 (id:40001) has been deleted

[Benedikt Meurer, 2015-08-21 10:24:55]

Patchset #1 (id:60001) has been deleted

[Benedikt Meurer, 2015-08-21 10:25:03]

Patchset #1 (id:80001) has been deleted

[Benedikt Meurer, 2015-08-21 10:25:09]

Patchset #1 (id:100001) has been deleted

[Benedikt Meurer, 2015-08-21 10:25:18]

Patchset #1 (id:120001) has been deleted

[Benedikt Meurer, 2015-08-21 10:27:57]

bmeurer@chromium.org changed reviewers:
+ mstarzinger@chromium.org, plind44@gmail.com, v8-mips-ports@googlegroups.com,
yangguo@chromium.org

[Benedikt Meurer, 2015-08-21 10:27:58]

Yang: Please do the overall review.
Michi: Please take a look at the TF changes.

MIPS people: Please port this to MIPS and MIPS64.

[Michael Starzinger, 2015-08-21 10:32:35]

LGTM on TurboFan, CodeFactory and InterfaceDescriptor. Didn't look at the rest.

[Yang, 2015-08-24 07:30:49]

On 2015/08/21 10:32:35, Michael Starzinger wrote:
> LGTM on TurboFan, CodeFactory and InterfaceDescriptor. Didn't look at the
rest.

LGTM with a comment. Please wait for the MIPS port before landing.

[Yang, 2015-08-24 07:31:06]

... and the comment

https://codereview.chromium.org/1304633002/diff/180001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/1304633002/diff/180001/src/arm/code-stubs-arm...
src/arm/code-stubs-arm.cc:1305: // Lookup the {function} and the {object} map in
the global instanceof cache.
Please add a comment here or somewhere appropriate that this works because we
delete the cache when we set the prototype of any object.

[Benedikt Meurer, 2015-08-24 07:37:47]

https://codereview.chromium.org/1304633002/diff/180001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/1304633002/diff/180001/src/arm/code-stubs-arm...
src/arm/code-stubs-arm.cc:1305: // Lookup the {function} and the {object} map in
the global instanceof cache.
On 2015/08/24 07:31:06, Yang wrote:
> Please add a comment here or somewhere appropriate that this works because we
> delete the cache when we set the prototype of any object.

Done.

[akos.palfi.imgtec, 2015-08-24 10:51:30]

akos.palfi@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com

[akos.palfi.imgtec, 2015-08-24 10:51:31]

Hi Benedikt - We are working on the mips port, will upload the port ASAP.

[paul.l..., 2015-08-25 01:30:53]

Hey Benedikt - MIPS ports in https://codereview.chromium.org/1316543002/

[Benedikt Meurer, 2015-08-25 04:23:33]

On 2015/08/25 01:30:53, paul.l... wrote:
> Hey Benedikt - MIPS ports in https://codereview.chromium.org/1316543002/

Thanks a lot!

[Benedikt Meurer, 2015-08-25 04:23:53]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-08-25 04:23:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1304633002/#ps240001
(title: "REBASE. Add MIPS/MIPS64 ports.")

[commit-bot: I haz the power, 2015-08-25 04:24:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304633002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304633002/240001

[commit-bot: I haz the power, 2015-08-25 04:48:45]

Committed patchset #5 (id:240001)

[commit-bot: I haz the power, 2015-08-25 04:49:04]

Patchset 5 (id:??) landed as
https://crrev.com/5d875a57fa2e65c1a4a6b50aeb23c38299c3cfbc
Cr-Commit-Position: refs/heads/master@{#30342}