Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1304633002: Correctify instanceof and make it optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Add MIPS/MIPS64 ports. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 4780 matching lines...) Expand 10 before | Expand all | Expand 10 after
4791 switch (op) { 4791 switch (op) {
4792 case Token::IN: 4792 case Token::IN:
4793 VisitForStackValue(expr->right()); 4793 VisitForStackValue(expr->right());
4794 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION); 4794 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION);
4795 PrepareForBailoutBeforeSplit(expr, false, NULL, NULL); 4795 PrepareForBailoutBeforeSplit(expr, false, NULL, NULL);
4796 __ CompareRoot(x0, Heap::kTrueValueRootIndex); 4796 __ CompareRoot(x0, Heap::kTrueValueRootIndex);
4797 Split(eq, if_true, if_false, fall_through); 4797 Split(eq, if_true, if_false, fall_through);
4798 break; 4798 break;
4799 4799
4800 case Token::INSTANCEOF: { 4800 case Token::INSTANCEOF: {
4801 VisitForStackValue(expr->right()); 4801 VisitForAccumulatorValue(expr->right());
4802 InstanceofStub stub(isolate(), InstanceofStub::kNoFlags); 4802 __ Pop(x1);
4803 InstanceOfStub stub(isolate());
4803 __ CallStub(&stub); 4804 __ CallStub(&stub);
4804 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4805 PrepareForBailoutBeforeSplit(expr, false, NULL, NULL);
4805 // The stub returns 0 for true. 4806 __ CompareRoot(x0, Heap::kTrueValueRootIndex);
4806 __ CompareAndSplit(x0, 0, eq, if_true, if_false, fall_through); 4807 Split(eq, if_true, if_false, fall_through);
4807 break; 4808 break;
4808 } 4809 }
4809 4810
4810 default: { 4811 default: {
4811 VisitForAccumulatorValue(expr->right()); 4812 VisitForAccumulatorValue(expr->right());
4812 Condition cond = CompareIC::ComputeCondition(op); 4813 Condition cond = CompareIC::ComputeCondition(op);
4813 4814
4814 // Pop the stack value. 4815 // Pop the stack value.
4815 __ Pop(x1); 4816 __ Pop(x1);
4816 4817
(...skipping 583 matching lines...) Expand 10 before | Expand all | Expand 10 after
5400 } 5401 }
5401 5402
5402 return INTERRUPT; 5403 return INTERRUPT;
5403 } 5404 }
5404 5405
5405 5406
5406 } // namespace internal 5407 } // namespace internal
5407 } // namespace v8 5408 } // namespace v8
5408 5409
5409 #endif // V8_TARGET_ARCH_ARM64 5410 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698